Resolve todos in the codebase #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
force-pushed
the
feature/mininny/resolve-todos
branch
from
d87e934
to
c26f8bb
Compare
mininny
force-pushed
the
feature/mininny/resolve-todos
branch
from
c26f8bb
to
5d087c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 60.84% 60.17% -0.67%
==========================================
Files 26 26
Lines 3833 3802 -31
==========================================
- Hits 2332 2288 -44
- Misses 1385 1390 +5
- Partials 116 124 +8 ☔ View full report in Codecov by Sentry. |
mininny
commented
Oct 18, 2024
clabby
reviewed
Oct 18, 2024
ImTei
reviewed
Oct 21, 2024
mininny
force-pushed
the
feature/mininny/resolve-todos
branch
from
eb34592
to
22f0c71
Compare
ImTei
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some TODOs in the codebase.